Skip to content

Port create_php_tags to Python3 and generate new PHP tags file #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2023

Conversation

eht16
Copy link
Member

@eht16 eht16 commented May 7, 2023

Related to #2615.

I don't know how good the newly generated tags are, my PHP knowledge is basically non-existent anymore :). At least, the diff looks like some were added, removed and changed, some keep even unchanged.

@eht16
Copy link
Member Author

eht16 commented May 7, 2023

When #3039 is merged, I would adjust the script to generate ctags file format and share the code with the Python tags script.

Copy link

@cwendling cwendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much PHP anymore either, but at least the script seems to still work, the difference seem to be in the JSON itself (I only checked a couple things, but they match).
Sadly the JSON seems to have a few flaws with the types in signatures (no alternative types, and it seems to use the last one which sometimes is null -- that used to be mixed in the PHP docs, but now is foo|bar|baz), but then again nothing the script can do with that data so I'd think it's fine.

@elextr
Copy link
Member

elextr commented May 9, 2023

Is there a reason that Python tags are in ctags format and php tags in tagmanager?

@eht16 eht16 force-pushed the update_php_script_and_tags branch from 36ccb38 to 721550c Compare May 10, 2023 21:34
@eht16
Copy link
Member Author

eht16 commented May 10, 2023

Is there a reason that Python tags are in ctags format and php tags in tagmanager?

Before #3039, Python tags were also in tagmanager format and so are the PHP tags.

As said in #3488 (comment), I would switch the format to ctags for the PHP tags as well. But I'd like to make this iterative to avoid a huge "I do it all in one"-PR :).

@eht16 eht16 merged commit 82502cf into geany:master May 21, 2023
@eht16 eht16 deleted the update_php_script_and_tags branch May 21, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants