Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breathing room in the navbar #15

Closed
codebrainz opened this issue Aug 25, 2019 · 4 comments

Comments

@codebrainz
Copy link
Member

commented Aug 25, 2019

The navbar feels kind of cramped, IMO. I don't know how to work on this site locally, but I hacked a prototype in Chromium devtools.

Before:

before

After:

after

I made the following changes:

  • On the logo image I set the top, right and bottom margins to .5em
  • On the logo text I set the line-height to 2em (FIXME: not perfectly centered vertically)
  • On the anchors in the nav menu, I set line-height to 3em.
  • On the nav menu <ul> I added the class navbar-right.
  • On the hamburger button, set the margin-top to 1em. (FIXME: probably not right way to centre vertically).
@b4n

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

Looks pretty good, and I especially like the additional spacing between the logo and the name 👍

@eht16

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

@codebrainz running the site locally is as easy as: make docker-build && make docker-run.
https://github.com/geany/www.geany.org/blob/master/README.dev.md has all the boring details.

Afterwards, it should be easy to create a PR.
I'm not very keen on replaying your described changes on the code.

@codebrainz

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@eht16 cool, I'll try it out and if I can get it working I'll replace my latest Issues with Pull Requests. Thanks!

Update: got it working locally by using RTFM, nice!

@codebrainz codebrainz referenced this issue Aug 27, 2019
@codebrainz

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

I'm closing this since I have no idea how/where to make these changes.

@codebrainz codebrainz closed this Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.