Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancify navbar #16

Closed
codebrainz opened this issue Aug 25, 2019 · 4 comments

Comments

@codebrainz
Copy link
Member

commented Aug 25, 2019

In addition to #15, the navbar looks cool with these changes:

  • Make the navbar background color rgba(0, 0, 0, 0.9)
  • Add box-shadow: 0 4px 2px -2px rgba(0, 0, 0, 0.2) to the navbar.

I'm sure the values could be tweaked a bit.

Obligatory screenshot:

fancy

@b4n

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

I don't really like the transparency, I think it makes everything a lot less readable.
For the subtle shadow, yeah it's probably a good idea.

@codebrainz

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

I think it makes everything a lot less readable

What is "everything" in this context? If you mean the text under the navbar, that's the intention. If you mean the text on the navbar, that could be made even better with some other changes, I just got tired of editing in Chromium devtools since it doesn't save my changes, and it's tedious to use.

@b4n

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

I meant the content of the navbar; I think the transparency adds background noise that makes it harder to read the foreground text. It possibly could be improved by blurring what's underneath (not sure it's possible even in 2019s web browsers?), or by enhancing foreground contrast, or whatnot. But anyway I'm questioning whether that transparency effect adds anything?

@codebrainz

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Whenever I work on this I'll re-open.

@codebrainz codebrainz closed this Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.