Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set font size #17

Closed
codebrainz opened this issue Aug 25, 2019 · 9 comments

Comments

@codebrainz
Copy link
Member

commented Aug 25, 2019

The current font size (rendered as 14px here) seems a little small. To me it looks better by using browser default of 16px (typical).

@elextr

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

Plis add pitcha for the web tools illiterate (me).

@elextr

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

Probably better if all font sizes were in ems not px, I'm sure on @codebrainz 4k monitor 14px is small but its ok on my 2k and huge on the laptop.

(or maybe @codebrainz just needs glasses 😁 )

@codebrainz

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

Probably better if all font sizes were in ems not px

em is relative to the parent font size, at somewhere you have to set pixel size for the (r)em to be relative to.

I'm sure on @codebrainz 4k monitor 14px is small

I have 3 monitors, only one is 4k.

@elextr

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

ems and rems are ultimately based on the browser setting (unless somebody hard coded a px somewhere in the inheritance tree). The browser setting is controlled by the user to make text readable to them, webpages should not override the user by hard setting px when they don't know what device it is shown on.

@codebrainz

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

It is common practice for websites to set their base font size using pixels. And they do know what device it is shown on, for example they can adjust the font size depending on the viewport size/orientation.

User agents are free to override this, I'm sure all browsers support it.

Edit: just to be clear, I'm not opposed to not setting a base font (and usually getting 16px by default), I just think the current 14px is too small.

@elextr

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

And as usual the web is dominated by the wrong way to do things, from the Mozilla docs:

Note: Defining font sizes in px is not accessible, because the user cannot change the font size from the browser. For example, users with limited vision may wish to set the font size much larger than the size chosen by a web designer. Avoid using them for font sizes if you wish to create an inclusive design.
@elextr

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

just to be clear, I'm not opposed to not setting a base font (and usually getting 16px by default), I just think the current 14px is too small.

So maybe 1em or 1.1em.

@codebrainz

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

1em is fine (with default browser size of 16px).

@codebrainz codebrainz changed the title Font size Don't set font size Aug 25, 2019

@codebrainz

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

I'm closing until I figure out how the website works, "soon".

@codebrainz codebrainz closed this Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.