From 6ca3f045dcc6725eceb4d44c22e38f22de22c1f2 Mon Sep 17 00:00:00 2001 From: Alexei Pastuchov Date: Wed, 21 Nov 2018 07:48:12 +0100 Subject: [PATCH] remove file if mkstemp succeeded --- libtest/signal.cc | 8 ++++---- util/signal.cc | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libtest/signal.cc b/libtest/signal.cc index 2921f7143..48901b073 100644 --- a/libtest/signal.cc +++ b/libtest/signal.cc @@ -216,11 +216,11 @@ SignalThread::SignalThread() : sigaddset(&set, SIGUSR2); strcpy(lock_name, "/XXXXXXXX"); - if (mkstemp(lock_name) == -1) + // random lock_name required + if (mkstemp(lock_name) != -1) { - // it doesn't matter - // mkstemp should get random lock_name - // Error << strerror(errno) << " mkstemp failed."; + // remove unnecessary file + remove(lock_name); } sigemptyset(&original_set); diff --git a/util/signal.cc b/util/signal.cc index 8371c1dc0..7723cc248 100644 --- a/util/signal.cc +++ b/util/signal.cc @@ -206,11 +206,11 @@ SignalThread::SignalThread(bool exit_on_signal_arg) : sigaddset(&set, SIGUSR2); strcpy(lock_name, "/XXXXXXXXX"); - if (mkstemp(lock_name) == -1) + // random lock_name required + if (mkstemp(lock_name) != -1) { - // it doesn't matter - // mkstemp should get random lock_name - // std::cerr << strerror(errno) << " mkstemp failed."; + // remove unnecessary file + remove(lock_name); } }