New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FirefoxDriver configuration to allow automatic basic auth with http://user:pass@host.tld #28

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@paulwellnerbou
Contributor

paulwellnerbou commented Jul 12, 2017

This configuration allows you to use basic authentification with, for example

baseUrl = http://user:password@host.tld

Not sure, if you want this to be integrated in your master branch. But if not, this pull request may serve as documentation and example on how to achieve this.

@erdi

This comment has been minimized.

Show comment
Hide comment
@erdi

erdi Jul 16, 2017

Member

Hi @paulwellnerbou,

Thanks for your contribution but as you have anticipated I will not be merging this into master. Your changes, while probably valuable for your particular use case, have not much to do with this example and do not influence the result of running the tests that constitute this project. While it might feel useful for you, showing all possible configuration options will unnecessarily bloat this project and make it harder to understand for newcomers. I would like to keep it as lean as possible and not include a single line of code that is not necessary to get the tests passing.

Thanks for your understanding.

Member

erdi commented Jul 16, 2017

Hi @paulwellnerbou,

Thanks for your contribution but as you have anticipated I will not be merging this into master. Your changes, while probably valuable for your particular use case, have not much to do with this example and do not influence the result of running the tests that constitute this project. While it might feel useful for you, showing all possible configuration options will unnecessarily bloat this project and make it harder to understand for newcomers. I would like to keep it as lean as possible and not include a single line of code that is not necessary to get the tests passing.

Thanks for your understanding.

@erdi erdi closed this Jul 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment