New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide shortcut method for combining "to" and "at" #1

Closed
geb-bot opened this Issue Nov 1, 2010 · 7 comments

Comments

Projects
None yet
2 participants
@geb-bot

geb-bot commented Nov 1, 2010

Originally created by Luke Daley.

@geb-bot

This comment has been minimized.

geb-bot commented Dec 3, 2010

Originally posted by Robert Fletcher.

What would the purpose of this be? Doesn't 'to' already verify the page? If not, I think it should.

@geb-bot

This comment has been minimized.

geb-bot commented Dec 3, 2010

Originally posted by Luke Daley.

it doesn't, because the request may redirect to a different page.

@geb-bot

This comment has been minimized.

geb-bot commented Jun 4, 2011

Originally posted by Alexander Zolotov.

In most cases, after calling 'to' I'm checking that I am on right page. So you may want to insert verification of page in "to" method and come up with shortcut to changing page without verification.

For example:

  1. to SomePage - change page and verify it
  2. to SomePage, verify: false - change page without verification
@geb-bot

This comment has been minimized.

geb-bot commented Mar 20, 2012

Originally posted by Christoph Neuroth.

+1 on Alexanders suggestion. Any reasons against that?

@geb-bot

This comment has been minimized.

geb-bot commented Mar 21, 2012

Originally posted by Luke Daley.

The problem is that it clashes with this feature:

http://www.gebish.org/manual/current/page-navigation.html#advanced_page_navigation

My current thinking on this is that we should change to() to have this behaviour, but add a new maybeTo() method.

@geb-bot

This comment has been minimized.

geb-bot commented Aug 29, 2012

Originally posted by Marcin Erdmann.

Resolved in geb/geb@c84cbdd by adding toAt() method.

@geb-bot

This comment has been minimized.

geb-bot commented Aug 29, 2012

Resolved

@geb-bot geb-bot added the New feature label Apr 12, 2015

@geb-bot geb-bot added this to the 0.9.0 milestone Apr 12, 2015

@geb-bot geb-bot closed this Apr 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment