New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New width, height, x, w properties override form fields and page/module attributes. #109

Closed
geb-bot opened this Issue Aug 11, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@geb-bot

geb-bot commented Aug 11, 2011

Originally created by Kevin Richards.

If you have a form, module or page which contains the attributes width, height, x, y then they are broken in the 0.6.0 release.

An example would be a domain object for an Image with attributes url, width, height.

form.width now returns the width of the form NOT the value of the input field.

Similar problems for x,y,height exist.

I'd suggest that these shortcuts are only honoured IF there are no page/module/field attributes which match.

@geb-bot

This comment has been minimized.

geb-bot commented Apr 11, 2012

Originally posted by Luke Daley.

I think we should introduce an object that contains these 4 properties. So if we were to call it display.

thing.display.x

instead of

thing.x
@geb-bot

This comment has been minimized.

geb-bot commented Apr 11, 2012

Originally posted by Luke Daley.

Coming up with the right name may be tricky.

@geb-bot geb-bot added the Bug label Apr 12, 2015

@geb-bot geb-bot added this to the 0.10.1 milestone Apr 12, 2015

@erdi erdi modified the milestone: 0.10.1 Jul 11, 2015

@erdi erdi self-assigned this Dec 25, 2015

@erdi erdi added this to the 1.0 milestone Dec 25, 2015

@erdi

This comment has been minimized.

Member

erdi commented Dec 26, 2015

A InvalidPageContent exception is now thrown now when a content name that conflicts with any of these properties is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment