Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waiting, window closing and page switching options to withNewWindow() #167

Closed
geb-bot opened this issue Jan 23, 2012 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@geb-bot
Copy link

@geb-bot geb-bot commented Jan 23, 2012

Originally created by Marcin Erdmann.

And also throw an own exception when no window has been opened, now it looks like web driver is throwing the exception which is not the case.

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Apr 30, 2012

Originally posted by John Murph.

Just a comment on the page switching options. On the mailing list, Luke suggested this syntax:

withNewWindow({ /* opening action */}, page: SomePage) {}

Also, after the window closure (the body) returns the context should be automatically switched back to the calling context.

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Nov 7, 2012

Originally posted by Marcin Erdmann.

Fixed in geb/geb@5749221

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Nov 7, 2012

Resolved

@geb-bot geb-bot added the Improvement label Apr 12, 2015
@geb-bot geb-bot added this to the 0.9.0 milestone Apr 12, 2015
@geb-bot geb-bot closed this Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants