Only check if waitFor has timed out if the last evaluation returned a falsey value #215

Closed
geb-bot opened this Issue Sep 7, 2012 · 2 comments

Projects

None yet

2 participants

@geb-bot
geb-bot commented Sep 7, 2012

Originally created by Marcin Erdmann.

If your waitFor closure takes a lot of time or returns truthy value in last evaluation which started just before the timeout has passed then it will incorrectly throw WaitTimeoutException.

Add pass evaluation in this line: https://github.com/geb/geb/blob/master/module/geb-core/src/main/groovy/geb/waiting/Wait.groovy#L123

@geb-bot
geb-bot commented Sep 13, 2012

Originally posted by Marcin Erdmann.

Fixed in geb/geb@951c7c5

@geb-bot
geb-bot commented Sep 13, 2012

Resolved

@geb-bot geb-bot added the Bug label Apr 12, 2015
@erdi erdi was assigned by geb-bot Apr 12, 2015
@geb-bot geb-bot added this to the 0.9.0 milestone Apr 12, 2015
@geb-bot geb-bot closed this Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment