Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check if waitFor has timed out if the last evaluation returned a falsey value #215

Closed
geb-bot opened this issue Sep 7, 2012 · 2 comments
Closed

Only check if waitFor has timed out if the last evaluation returned a falsey value #215

geb-bot opened this issue Sep 7, 2012 · 2 comments
Assignees
@erdi
Labels
Bug
Milestone
0.9.0

Comments

@geb-bot
Copy link

geb-bot commented Sep 7, 2012

Originally created by Marcin Erdmann.

If your waitFor closure takes a lot of time or returns truthy value in last evaluation which started just before the timeout has passed then it will incorrectly throw WaitTimeoutException.

Add pass evaluation in this line: https://github.com/geb/geb/blob/master/module/geb-core/src/main/groovy/geb/waiting/Wait.groovy#L123
@geb-bot
Copy link
Author

geb-bot commented Sep 13, 2012

Originally posted by Marcin Erdmann.

Fixed in geb/geb@951c7c5

@geb-bot
Copy link
Author

geb-bot commented Sep 13, 2012

Resolved

@geb-bot geb-bot added the Bug label Apr 12, 2015
@geb-bot geb-bot added this to the 0.9.0 milestone Apr 12, 2015
@geb-bot geb-bot closed this as completed Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erdi erdi

Labels
Bug
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@erdi @geb-bot