Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isAt() should set page to the one passed as the argument if verification succeeds #227

Closed
geb-bot opened this issue Oct 26, 2012 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@geb-bot
Copy link

@geb-bot geb-bot commented Oct 26, 2012

Originally created by Marcin Erdmann.

isAt() should behave exactly the same way as at does with only the difference in not throwing an exception when verification fails, this is not the case as of now

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Oct 26, 2012

Originally posted by Luke Daley.

I don't understand the description here.

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Oct 30, 2012

Originally posted by Marcin Erdmann.

what I meant is that at() sets the browser's page field to the page passed as the argument if the verification succeeds:
{noformat}
at MyPage
assert browser.page instanceof MyPage
{noformat}

It's not the case for isAt() though:
{noformat}
assert isAt(MyPage)
assert !(browser.page instanceof MyPage)
{noformat}

After thinking about it for a while I'm starting to think that's actually the right thing that isAt() doesn't modify the page field.. So I'm in favour of marking this issue as 'not an issue'.

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Nov 10, 2012

Resolved

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Nov 10, 2012

Originally posted by Marcin Erdmann.

resolved by geb/geb@8db7a10

@geb-bot geb-bot added the Improvement label Apr 12, 2015
@geb-bot geb-bot added this to the 0.9.0 milestone Apr 12, 2015
@geb-bot geb-bot closed this Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants