Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waiting configuration for at checks #253

Closed
geb-bot opened this issue Apr 4, 2013 · 3 comments
Closed

Add waiting configuration for at checks #253

geb-bot opened this issue Apr 4, 2013 · 3 comments
Assignees
Labels
Milestone

Comments

@geb-bot
Copy link

@geb-bot geb-bot commented Apr 4, 2013

Originally created by Marcin Erdmann.

As discussed in this thread: http://markmail.org/thread/4katbc6scowgwsuv

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Jul 30, 2013

Originally posted by Marcin Erdmann.

Fixed in geb/geb@6275f45

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Jul 30, 2013

Resolved

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Aug 2, 2013

Originally posted by Luke Daley.

This is a great change.

The only thing I'm unsure about is the name of the config param. “waitForAtCheck” doesn't quite capture it.

I think “atCheckWaiting” might be better. What do you think?

@geb-bot geb-bot added the New feature label Apr 12, 2015
@geb-bot geb-bot added this to the 0.9.1 milestone Apr 12, 2015
@geb-bot geb-bot closed this Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants