Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support navigating to page instances in addition to classes #310

Closed
geb-bot opened this issue May 15, 2014 · 1 comment
Closed

Support navigating to page instances in addition to classes #310

geb-bot opened this issue May 15, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@geb-bot
Copy link

@geb-bot geb-bot commented May 15, 2014

Originally created by Luke Daley.

it should be possible to do:


class ProductPage extends Page {
  String productId

  ProductPage(String productId) {
    this.productId = productId 
  } 

  static at = { title == "Product '$productId'" }
}

to new ProductPage("myId")

After this change, to(SomePage) becomes just shorthand for to(new SomePage()).

We will have to add some formal kind of notion of initialised to Pages. Initialisation is performed by Geb (in Browser) which is where the backing navigator is attached to the Page instance.

If a user tries to use Geb functionality (e.g. Navigator method) on an uninitialised page they should get an appropriate error.

If they try to initialise an already initialised page they should get an appropriate error message (e.g. to(to(new SomePage())).

@geb-bot
Copy link
Author

@geb-bot geb-bot commented Dec 15, 2014

Resolved

@geb-bot geb-bot added the Improvement label Apr 12, 2015
@geb-bot geb-bot added this to the 0.10.1 milestone Apr 12, 2015
@geb-bot geb-bot closed this Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants