New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message thrown from Navigator.isDisabled() and Navigator.isReadOnly() when navigator does not contain a form element #345

Closed
geb-bot opened this Issue Oct 27, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@geb-bot

geb-bot commented Oct 27, 2014

Originally created by Marcin Erdmann.

The message should include as much info about the element for which the check failed as possible (at least the tag name, could also use WebElement.toString() if it's informative and relatively consistent across drivers).

The check should be also done for all elements of the navigator, not just the first one.

@geb-bot

This comment has been minimized.

geb-bot commented Dec 16, 2014

Originally posted by Chris Prior.

The current behaviour of disabled() & readOnly() is to only check the first element in the navigator. This is therefore consistent with the check for only the first element being in the list of supported tags for the operation.

Was your intention to change this behaviour to check all elements in the navigator to see for instance whether they were all disabled?

@geb-bot

This comment has been minimized.

geb-bot commented Dec 16, 2014

Originally posted by Marcin Erdmann.

You are probably right that there is no point in checking more than the first element because isDisabled() and isReadOnly() operate on the first element only.

There is https://jira.codehaus.org/browse/GEB-284 which will prevent calling these methods on multi element navigators anyway.

We're probably good to close this one now.

@geb-bot

This comment has been minimized.

geb-bot commented Dec 18, 2014

Resolved

@geb-bot geb-bot added the Improvement label Apr 12, 2015

@geb-bot geb-bot closed this Apr 12, 2015

@erdi erdi added this to the 0.10.1 milestone Jul 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment