Skip to content

CachingDriverFactory.ThreadLocalCache performance #421

Closed

Description

@schillingr

When running UI tests in a thread (thread per Specification), the synchronized nature of ThreadLocalCache impacts performance dramatically. Since ThreadLocalCache uses a ThreadLocal as a backing store it is already thread-safe and the synchronized get() shouldn't be necessary.

In local testing it saved ~7 minutes of runtime @ 50 threads (1 grid node per thread), which equated to about a 30% speed improvement.

Activity

  1. added this to the 0.13.1 milestone on Feb 20, 2016
  2. self-assigned this
    on Feb 20, 2016
  3. erdi commented on Feb 20, 2016

    @erdi
    Member

    Thanks for reporting @schillingr. You are right, synchronizing these methods was totally unnecessary. The fix will be part of 0.13.1 which will be released imminently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions