Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save frames along with parent HTML #448

Closed
prabhjot-bb opened this Issue Sep 2, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@prabhjot-bb
Copy link

prabhjot-bb commented Sep 2, 2016

Currently, the page reporter only saves the parent HTML without frames. As is the saved HTML is not of much use when parent has only frames. Request to enhance the PageSourceReporter to save frames as well.

@erdi

This comment has been minimized.

Copy link
Member

erdi commented Sep 4, 2016

I agree but this should be an opt-in extension in a form of a FramesSourceReporter and not a change to PageSourceReporter because it will need to find all frames on the page by executing a WebDriver command which will carry a performance penalty for people whose tests are not dealing with sites using frames.

@erdi erdi added the Improvement label Sep 4, 2016

@ghost ghost referenced this issue Nov 9, 2017

Closed

#448 Save frames #131

@ghost

This comment has been minimized.

Copy link

ghost commented Nov 9, 2017

frame_test1.txt
I have tried to address this issue via geb/geb#131 without creating a new FramesSourceReporter. Sample output attached.

@erdi erdi added this to the 2.1 milestone Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.