New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GebReportingTest (Junit) does not report failures #491

Closed
darionct opened this Issue Jun 29, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@darionct

darionct commented Jun 29, 2017

Due to the order of JUnit execution of rules and life-cycle methods (@After), Geb does not report failures because failureTracker flag is set AFTER writeGebReport() is called so it will never be true.

This issue is similar to the #445. Possible solution is explained in junit-team/junit4#906 , but it is not simple since the browser instance is null when the TestWatcher is called.

@erdi

This comment has been minimized.

Member

erdi commented Jun 30, 2017

Thanks for reporting, I will look into it, sounds like a possible issue. Testing code that is participating in test framework's lifecycle is sometimes hard to get right.

@erdi erdi added this to the 2.1 milestone Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment