GStrings in attribute selectors do not work

[robaca]

It should be possible to pass GStrings for attribute values.

The following content definition does not resolve:

accountLink { id -> $('a', href: "/account/$id/profile") }

but the following does:

accountLink { id -> $('a', href: "/account/$id/profile" as String) }

It took me an hour to find the problem, as I just did expect id had to work.

[erdi]

Can you please confirm which version of Geb you are seeing this with, Carsten?

…

On Tue, 29 May 2018 at 07:32, Carsten Rohrbach ***@***.***> wrote: It should be possible to pass GStrings for attribute values. The following content definition does not resolve: accountLink { id -> $('a', href: "/account/$id/profile") } but the following does: accountLink { id -> $('a', href: "/account/$id/profile" as String) } It took me an hour to find the problem, as I just did expect id had to work. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#525>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMii_gVVjHUEgTEl7y2-cZKlg6Xj3-fks5t3OtpgaJpZM4UQ57P> .

[robaca]

@erdi I tried with geb-spock 2.0 and 2.1 (groovy 2.4.10)

[erdi]

So you tried with the latest, cool. I’ll take a look.

…

On Tue, 29 May 2018 at 11:32, Carsten Rohrbach ***@***.***> wrote: @erdi <https://github.com/erdi> I tried with geb-spock 2.0 and 2.1 (groovy 2.4.10) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#525 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMiizGVie9ukmj5EAvbiReBAoVPOLhhks5t3SPWgaJpZM4UQ57P> .

[erdi]

Thanks for reporting, this indeed was a bug.

The issue was more obscure than simply selection for GString attributes not working at all. Translation between attribute maps and css selectors indeed did not work for GString attributes which meant that it fell back to filtering in the JVM by retrieving attributes and then checking that against the provided value. In general filtering still worked but with somehow downgraded performance if you used GString attributes. It did not work anymore if the value returned for an attribute was different when retrieved using WebDriver commands from what was being matched using css selectors. The href attribute is one example because when retrieved using WebDriver the protocol and hostname are prepended to its value but protocol and hostname are not required when matching using a css attribute selector. So you were somewhat unlucky to encounter the issue but on the other hand thanks to that happening it has been discovered and is now fixed.