Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book of Geb: anker link for chapter 7.2.4 leads to 2.2.1 #535

Closed
kriegaex opened this issue Jul 24, 2018 · 3 comments
Closed

Book of Geb: anker link for chapter 7.2.4 leads to 2.2.1 #535

kriegaex opened this issue Jul 24, 2018 · 3 comments
Milestone

Comments

@kriegaex
Copy link

@kriegaex kriegaex commented Jul 24, 2018

When clicking on the headline of chapter "7.2.4. Base URL", you are taken to chapter 2.2.1. The base URL instead, obviously because they both have the same anker "#base-url". I noticed when trying to send someone on StackOverflow a link to 7.2.4 and it did not work. So I sent him a link to 7.2.3 instead and told him to scroll down, which is a bit awkward.

I suggest to fix this little glitch by assigning two different anker IDs.

@erdi erdi added this to the 2.2 milestone Jul 30, 2018
@erdi
Copy link
Member

@erdi erdi commented Jul 30, 2018

Thanks for reporting. I'll add a check which will fail the build if there are anchors with the same ids in the manual so this does not happen again and then I'll fix it.

@kriegaex
Copy link
Author

@kriegaex kriegaex commented Aug 3, 2018

I took a quick look over your commit. Looks good to me. I like the fact that you have an automated test in order to detect future regressions. This is in the spirit of Spock and Geb. ;-) Thank you.

@erdi
Copy link
Member

@erdi erdi commented Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants