New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range input module #551

Closed
mkutz opened this Issue Dec 7, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@mkutz
Copy link

mkutz commented Dec 7, 2018

Geb should have a module for range inputs. See specification in HTML 5.2 or documentation at W3Schools.

@mkutz

This comment has been minimized.

Copy link

mkutz commented Dec 17, 2018

The range input is very similar to the number input. It might be a worth creating a NumberLikeInput. Opinions?

@erdi

This comment has been minimized.

Copy link
Member

erdi commented Dec 17, 2018

Yeah, I agree. As far as I can tell it will be pretty much the same from Geb's point of view other than the different input type name.

mkutz added a commit to mkutz/geb that referenced this issue Dec 17, 2018

Add RangeInput
Since NumberInput and RangeInput are pretty similar, their shared
attributes have been moved to new NumberLikeInput.

See
https://www.w3.org/TR/2017/REC-html52-20171214/sec-forms.html#range-state-typerange

Contributes to geb/issues#551
@mkutz

This comment has been minimized.

Copy link

mkutz commented Dec 17, 2018

I again had to implement the tests as real browser tests. It seems that HtmlUnit is generally bad at supporting fancy input types. We should keep an eye on these tests.

Maybe it is also worth thinking about a different test setup, that does not require Sauce Labs or similar external services. In my geb-testing-workshop I'm using Docker on Travis to fire up a local Selenium container. Maybe that's an idea to improve local development on Geb itself.

mkutz added a commit to mkutz/geb that referenced this issue Dec 17, 2018

mkutz added a commit to mkutz/geb that referenced this issue Dec 17, 2018

mkutz added a commit to mkutz/geb that referenced this issue Dec 17, 2018

mkutz added a commit to mkutz/geb that referenced this issue Dec 18, 2018

Fix MonthInputSnippetSpec
The name attribute in the HTML differed from the one used to find the
element.

Contributes to geb/issues#551

mkutz added a commit to mkutz/geb that referenced this issue Dec 18, 2018

Fix MonthInputSnippetSpec
Using right property now.

Contributes to geb/issues#551
@erdi

This comment has been minimized.

Copy link
Member

erdi commented Dec 18, 2018

The thing is that SauceLabs is there because Geb is tested with a wider matrix of browsers (including IE and Safari) than what is available in a docker container. So SauceLabs and BrowserStack setup is there to stay and I don't feel like adding another mechanism to do the same thing but locally especially given the small set of tests that are annotated with @RequiresRealBrowser. I appreciate that it's a bit painful to work on the ones that are but on the other hand having a different setup for CI and local will most likely lead to the local setup rotting and not working anymore because of how little it will be used.

@erdi

This comment has been minimized.

Copy link
Member

erdi commented Dec 18, 2018

Thinking about it a bit more, we could probably replace the tasks running against chrome and FF on Linux in SauceLabs/BrowserStack to run locally. We already have these browsers installed in the docker image used on CI anyway. Would you care to create an issue for this?

@mkutz

This comment has been minimized.

Copy link

mkutz commented Dec 18, 2018

Done. See #555. Feel free to edit.

@erdi erdi assigned erdi and mkutz and unassigned erdi Dec 19, 2018

@erdi erdi added the New feature label Dec 19, 2018

@erdi erdi added this to the 2.3 milestone Dec 19, 2018

@erdi erdi closed this Dec 19, 2018

mkutz added a commit to mkutz/geb that referenced this issue Dec 20, 2018

Fix MonthInputSnippetSpec
The name attribute in the HTML differed from the one used to find the
element.

Contributes to geb/issues#551

mkutz added a commit to mkutz/geb that referenced this issue Dec 20, 2018

Fix MonthInputSnippetSpec
Using right property now.

Contributes to geb/issues#551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment