New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add week input module #553

Closed
mkutz opened this Issue Dec 7, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@mkutz
Copy link

mkutz commented Dec 7, 2018

Geb should have a module for month inputs. See specification in HTML 5.2 or documentation at W3Schools

@mkutz

This comment has been minimized.

Copy link

mkutz commented Dec 17, 2018

Any idea for an object type for this? There is no java.time.YearWeek (yet). My current approach would be to use two Integer properties (year and week).

@erdi

This comment has been minimized.

Copy link
Member

erdi commented Dec 17, 2018

I'd use org.threeten.extra.YearWeek from ThreeTen extra. I'm happy with the additional dependency.

mkutz added a commit to mkutz/geb that referenced this issue Dec 19, 2018

Add WeekInput
For the lag of a java.time.YearWeek, the current implementation uses
org.threeten.extra.YearWeek.

See
https://www.w3.org/TR/2017/REC-html52-20171214/sec-forms.html#week-state-typeweek

Contributes to geb/issues#553

mkutz added a commit to mkutz/geb that referenced this issue Dec 19, 2018

Fix WeekInputSnippetSpec
Used wrong name to find the element.

Contributes to geb/issues#553

@erdi erdi added this to the 2.3 milestone Dec 19, 2018

@erdi erdi added the New feature label Dec 19, 2018

mkutz added a commit to mkutz/geb that referenced this issue Dec 19, 2018

Fix WeekInputSnippetSpec
Used wrong property to get week.

Contributes to geb/issues#553

mkutz added a commit to mkutz/geb that referenced this issue Dec 20, 2018

Add WeekInput
For the lag of a java.time.YearWeek, the current implementation uses
org.threeten.extra.YearWeek.

See
https://www.w3.org/TR/2017/REC-html52-20171214/sec-forms.html#week-state-typeweek

Contributes to geb/issues#553
@erdi

This comment has been minimized.

Copy link
Member

erdi commented Dec 21, 2018

Thanks, @mkutz!

@erdi erdi closed this Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment