Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch cloud driver factories to use https urls #599

Closed
erdi opened this issue Nov 4, 2019 · 3 comments
Closed

Switch cloud driver factories to use https urls #599

erdi opened this issue Nov 4, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@erdi
Copy link
Member

@erdi erdi commented Nov 4, 2019

No description provided.

@erdi erdi added this to the 3.3 milestone Nov 22, 2019
@erdi erdi self-assigned this Nov 22, 2019
@erdi erdi added the Improvement label Nov 22, 2019
@pail-Rider

This comment has been minimized.

Copy link

@pail-Rider pail-Rider commented Dec 18, 2019

Hi @erdi This is a very timely improvement as my security team have just picked up that my browserstack creds are being sent via http rather than https. Is there a timescale for when this will go into a release?

@erdi

This comment has been minimized.

Copy link
Member Author

@erdi erdi commented Dec 18, 2019

I currently do not have a timescale for the next release. Thankfully you don't need it, simply add a class in your project which extends BrowserStackDriverFactory, override the assembleProviderUrl() method to return the same thing as in geb/geb@de97e5a and then use that new class instead of using BrowserStackDriverFactory.

@pail-Rider

This comment has been minimized.

Copy link

@pail-Rider pail-Rider commented Dec 19, 2019

aha yes of course. That worked a treat. Thanks @erdi for the quick response and all the work you do on this project. It's much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.