Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of TunnelId with TunnelName #606

Closed
ArpitLT opened this issue Mar 8, 2020 · 0 comments
Closed

Renaming of TunnelId with TunnelName #606

ArpitLT opened this issue Mar 8, 2020 · 0 comments
Milestone

Comments

@ArpitLT
Copy link

ArpitLT commented Mar 8, 2020

We would like to rename tunnelId with tunnelName for a better convention for the end users, as we have tunnelId and tunnelName as two different convention for LambdaTest tunnel, where tunnelId is an integer value which is uniquely generated for each LambdaTest tunnel.

In Geb code, following changes are required:

  1. doc/manual/src/docs/asciidoc/111-cloud-browsers.adoc as:
def tunnelName = System.getenv("GEB_LAMBDATEST_TUNNEL_NAME")
  assert tunnelName
  new LambdaTestDriverFactory().create(lambdaTestBrowser, username, accessKey, tunnelName)
  1. integration/geb-gradle/src/main/groovy/geb/gradle/lambdatest/LambdaTestTunnelOps.groovy
    Replace LOCAL_ID_ENV_VAR to TUNNEL_NAME_ENV_VAR
    Replace GEB_LAMBDATEST_TUNNELID to GEB_LAMBDATEST_TUNNEL_NAME

  2. module/geb-core/src/main/groovy/geb/driver/LambdaTestDriverFactory.groovy
    Replace tunnelId to tunnelName
    Replace GEB_LAMBDATEST_TUNNELID to GEB_LAMBDATEST_TUNNEL_NAME

@erdi erdi added this to the 4.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants