-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version of Browserstack Tunnel has different 'success' message #607
Comments
Thanks for reporting and the detailed analysis, @mgalos999. |
@erdi Sorry for rushing, do you have any ETA for 3.4 release? |
I think that with this and #608 a release will be in order sometime this week. |
@erdi stuck with gradle dependencies update after 3.4 release
And needed files aren't present here: https://repo.jfrog.org/artifactory/libs-release-bintray/org/gebish/geb-gradle/3.4/ |
Apologies for that, @garkinv, it should now be resolvable: https://search.maven.org/artifact/org.gebish/geb-gradle/3.4/jar. Publishing to Maven Central was flaky on Saturday morning when I was trying to release the first time and I obviously got it wrong on the second attempt. |
Yep, it works now, thank you! |
The Browserstack Tunnel is downloaded, launched and killed by the gradle-browserstack plugin.
When the tunnel is launched, the output text is checked for a specific success message.
Currently this text is
You can now access your local server(s) in our remote browser.
.However Browserstack have released a new version of the tunnel where the period is missing at the end of the message.
You can now access your local server(s) in our remote browser
This makes the plugin timeout as it doesn't find the exact text.
https://github.com/geb/geb/blob/master/integration/geb-gradle/src/main/groovy/geb/gradle/browserstack/BrowserStackTunnel.groovy
Looks like just the period needs to be removed and it will fix this problem while maintaining backward compatibility.
final String tunnelReadyMessage = 'You can now access your local server(s) in our remote browser.'
to
final String tunnelReadyMessage = 'You can now access your local server(s) in our remote browser'
The text was updated successfully, but these errors were encountered: