Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of Browserstack Tunnel has different 'success' message #607

Closed
mgalos999 opened this issue Mar 20, 2020 · 6 comments
Closed

Latest version of Browserstack Tunnel has different 'success' message #607

mgalos999 opened this issue Mar 20, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@mgalos999
Copy link

@mgalos999 mgalos999 commented Mar 20, 2020

The Browserstack Tunnel is downloaded, launched and killed by the gradle-browserstack plugin.
When the tunnel is launched, the output text is checked for a specific success message.
Currently this text is You can now access your local server(s) in our remote browser..
However Browserstack have released a new version of the tunnel where the period is missing at the end of the message. You can now access your local server(s) in our remote browser
This makes the plugin timeout as it doesn't find the exact text.

https://github.com/geb/geb/blob/master/integration/geb-gradle/src/main/groovy/geb/gradle/browserstack/BrowserStackTunnel.groovy

Looks like just the period needs to be removed and it will fix this problem while maintaining backward compatibility.
final String tunnelReadyMessage = 'You can now access your local server(s) in our remote browser.'
to
final String tunnelReadyMessage = 'You can now access your local server(s) in our remote browser'

@erdi erdi self-assigned this Mar 22, 2020
@erdi erdi added the Bug label Mar 22, 2020
@erdi erdi added this to the 3.4 milestone Mar 22, 2020
@erdi
Copy link
Member

@erdi erdi commented Mar 22, 2020

Thanks for reporting and the detailed analysis, @mgalos999.

@garkinv
Copy link

@garkinv garkinv commented Mar 24, 2020

@erdi Sorry for rushing, do you have any ETA for 3.4 release?

@erdi
Copy link
Member

@erdi erdi commented Mar 24, 2020

I think that with this and #608 a release will be in order sometime this week.

@garkinv
Copy link

@garkinv garkinv commented Mar 30, 2020

@erdi
Copy link
Member

@erdi erdi commented Mar 30, 2020

Apologies for that, @garkinv, it should now be resolvable: https://search.maven.org/artifact/org.gebish/geb-gradle/3.4/jar.

Publishing to Maven Central was flaky on Saturday morning when I was trying to release the first time and I obviously got it wrong on the second attempt.

@garkinv
Copy link

@garkinv garkinv commented Mar 30, 2020

Yep, it works now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants