Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LambdaTest tunnel has now a different tunnel ready message #608

Closed
ArpitLT opened this issue Mar 22, 2020 · 1 comment
Closed

LambdaTest tunnel has now a different tunnel ready message #608

ArpitLT opened this issue Mar 22, 2020 · 1 comment
Assignees
Milestone

Comments

@ArpitLT
Copy link

ArpitLT commented Mar 22, 2020

There is an issue with LambdaTest tunnel which gets timed out in polling mode through Jenkins due to different tunnel ready message with geb-lambdatest plugin when tunnel is started in polling mode instead of websocket mode. We have modified the tunnel ready message. This will fix the lambdatest tunnel getting started with Jenkins . We need your help @erdi in committing it.
Pull Request

final String tunnelReadyMessage = 'Tunnel claim successful'
to
final String tunnelReadyMessage = 'Secure connection established, you may start your tests now'

@ArpitLT ArpitLT changed the title Update the message searched for in LambdaTest tunnel process output… LambdaTest tunnel has now a different tunnel ready message Mar 22, 2020
@ArpitLT
Copy link
Author

ArpitLT commented Mar 25, 2020

Hi @erdi ,
Hope you're all well and safe in this Covid-19 outbreak. The LambdaTest tunnel can work in two modes: websocket and polling mode. However, in both modes, tunnelReady messages are different which caused problems when the tunnel is started in polling mode. This makes the plugin timeout as it doesn't find the exact text when tunnel starts in polling mode (with nows argument).

https://github.com/geb/geb/blob/master/integration/geb-gradle/src/main/groovy/geb/gradle/lambdatest/LambdaTestTunnel.groovy

To resolve this issue, we'd like you to update tunnelReadyMessage for which we've raised a pull request as well:

final String tunnelReadyMessage = 'Tunnel claim successful'
to
final String tunnelReadyMessage = 'Secure connection established, you may start your tests now'

@erdi erdi added this to the 3.4 milestone Mar 26, 2020
@erdi erdi self-assigned this Mar 26, 2020
@erdi erdi closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants