getHost helper seems redundant with config.fullHostname #307

Closed
mde opened this Issue Feb 5, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@mde
Contributor

mde commented Feb 5, 2013

@larzconwell, can we refactor getHost to use the config.fullHostname, or eliminate it completely?

@larzconwell

This comment has been minimized.

Show comment Hide comment
@larzconwell

larzconwell Feb 5, 2013

Contributor

Where is getHost defined at? I couldn't find it with grep.

Contributor

larzconwell commented Feb 5, 2013

Where is getHost defined at? I couldn't find it with grep.

@mde

This comment has been minimized.

Show comment Hide comment
@mde

mde Feb 5, 2013

Contributor

lib/template/helpers/utils.js

Also worth noting that sometimes both hostname and fullHostname will be null. Do we need this function for anything?

Contributor

mde commented Feb 5, 2013

lib/template/helpers/utils.js

Also worth noting that sometimes both hostname and fullHostname will be null. Do we need this function for anything?

@larzconwell

This comment has been minimized.

Show comment Hide comment
@larzconwell

larzconwell Feb 5, 2013

Contributor

Oh, the utils file is only for the url and tag helpers in index, none of the things in the file are exposed.

Though it could still use some refactoring to use the router probably.

Contributor

larzconwell commented Feb 5, 2013

Oh, the utils file is only for the url and tag helpers in index, none of the things in the file are exposed.

Though it could still use some refactoring to use the router probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment