Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Select Tag should let you specify a different value and text #325

Closed
MiguelMadero opened this Issue Mar 11, 2013 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

MiguelMadero commented Mar 11, 2013

Have a look at this SO question, it's sort of related to mde#227 so we might fix both.
Check template/helpers/utils.js@contentTagString around line 65

Contributor

mde commented Mar 11, 2013

Let's do it! I'm focusing this week (obviously) on getting us up to speed on Node 0.10, which looks like a pretty big job, so it would be fantastic if you could attack and fix this.

Also, would be fantastic if the SO question eventually gets answered, and points to whatever fix we come up with. Nice to have a proper public face on this.

Contributor

MiguelMadero commented Mar 11, 2013

Yes. I had a quick go earlier, but I had to leave, I just need to test it,
clean it and push.

Let me know if you need a hand with the 0.10 fixes.

Miguel

On Mon, Mar 11, 2013 at 12:19 PM, Matthew Eernisse <notifications@github.com

wrote:

Let's do it! I'm focusing this week (obviously) on getting us up to speed
on Node 0.10, which looks like a pretty big job, so it would be fantastic
if you could attack and fix this.

Also, would be fantastic if the SO question eventually gets answered, and
points to whatever fix we come up with. Nice to have a proper public face
on this.


Reply to this email directly or view it on GitHubhttps://github.com/mde/geddy/issues/325#issuecomment-14730702
.

@ghost ghost assigned MiguelMadero Mar 12, 2013

Contributor

akhoury commented Apr 14, 2013

I know this is closed, but is it possible to add support for any attribute on an option tag i.e 'data-*' instead just limiting to 'value' ? maybe something like:

selectTag( [ { text: "Text 1", attrs: { value: 1, data: {rate: "3.5" } } }, { text: "Text 2", attrs: { value: 2, data: {rate: 7} } } ], 2 );

// =>

<select><option value="1" data-rate="3.5">Text 1</option><option selected="selected" value="2" data-rate="7">Text 2</option></select>

akhoury added a commit to akhoury/geddy that referenced this issue Apr 14, 2013

akhoury added a commit to akhoury/geddy that referenced this issue Apr 15, 2013

akhoury added a commit to akhoury/geddy that referenced this issue Apr 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment