Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Mongo session #128

Merged
merged 3 commits into from Apr 28, 2012

Conversation

Projects
None yet
2 participants
Contributor

ekryski commented Apr 27, 2012

So I added the mongo session and made a couple minor tweaks to the redis session store.

In the redis store it was mainly just typos and fixing up variables that weren't properly scoped (however I didn't actually test it).

The mongo session store is very basic. Sessions will just stick around in the session database so I think eventually you guys might need a mechanism for flushing old ones. Also, there aren't any unit tests as I don't really think some of the stuff is set up to be very testable with plain old asserts. I did however, test it manually. If you would like me to add some unit tests I will but I would like to use mocha, should, and a small mocking library called stub.js. I have had some great success with those modules. Let me know if there is anything you want me to change!

@mde mde added a commit that referenced this pull request Apr 28, 2012

@mde mde Merge pull request #128 from ekryski/mongo-session
Mongo session
7b74c1d

@mde mde merged commit 7b74c1d into geddy:master Apr 28, 2012

Contributor

mde commented Apr 28, 2012

Merged, thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment