Adds braces and spaces after if #200

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@MiguelMadero
Contributor

MiguelMadero commented Sep 25, 2012

I only changed a handful of files. It's a bit of monkey coding, but I still don't want to break anything and I'm not familiar with other areas that I'd rather not touch for now.

@larzconwell

This comment has been minimized.

Show comment Hide comment
@larzconwell

larzconwell Sep 25, 2012

Contributor

Ah it's cool man I'm about to push now with all the changes for most of the syntax differences like the if, for, while, function, switch, try/catch, etc statements. I'm going to close this since it only covers the surface, thanks though mate!

Contributor

larzconwell commented Sep 25, 2012

Ah it's cool man I'm about to push now with all the changes for most of the syntax differences like the if, for, while, function, switch, try/catch, etc statements. I'm going to close this since it only covers the surface, thanks though mate!

@larzconwell

This comment has been minimized.

Show comment Hide comment
@larzconwell

larzconwell Sep 25, 2012

Contributor

Here's the commit if you're interested (: d9fe3bb

Contributor

larzconwell commented Sep 25, 2012

Here's the commit if you're interested (: d9fe3bb

@MiguelMadero

This comment has been minimized.

Show comment Hide comment
@MiguelMadero

MiguelMadero Sep 25, 2012

Contributor

Nice work. Definitely better and more consistent.

Contributor

MiguelMadero commented Sep 25, 2012

Nice work. Definitely better and more consistent.

@larzconwell

This comment has been minimized.

Show comment Hide comment
@larzconwell

larzconwell Sep 25, 2012

Contributor

Thanks, and thanks for contributing!

Contributor

larzconwell commented Sep 25, 2012

Thanks, and thanks for contributing!

@MiguelMadero

This comment has been minimized.

Show comment Hide comment
@MiguelMadero

MiguelMadero Sep 26, 2012

Contributor

I realized the templates don't use the same conventions. I changed a couple
MiguelMadero/geddy@a7e86f0
MiguelMadero/geddy@5f7888d

Contributor

MiguelMadero commented Sep 26, 2012

I realized the templates don't use the same conventions. I changed a couple
MiguelMadero/geddy@a7e86f0
MiguelMadero/geddy@5f7888d

@mde

This comment has been minimized.

Show comment Hide comment
@mde

mde Sep 26, 2012

Contributor

Y'all are awesome! Nice work.

Contributor

mde commented Sep 26, 2012

Y'all are awesome! Nice work.

@larzconwell larzconwell reopened this Sep 26, 2012

@larzconwell

This comment has been minimized.

Show comment Hide comment
@larzconwell

larzconwell Sep 26, 2012

Contributor

Oh nice catch @MiguelMadero! Pull down the new changes and I'll merge!

You'll probably get a few merge conflicts(I changed some of the if's to switch statements) with some of those if changes so it would probably be easier to just remove the first commit, or just open a new PR.

EDIT: Oops looks like you did pull the changes in. Just remove the first one including the old if changes and I'll merge it. Just include the generator template changes.

Contributor

larzconwell commented Sep 26, 2012

Oh nice catch @MiguelMadero! Pull down the new changes and I'll merge!

You'll probably get a few merge conflicts(I changed some of the if's to switch statements) with some of those if changes so it would probably be easier to just remove the first commit, or just open a new PR.

EDIT: Oops looks like you did pull the changes in. Just remove the first one including the old if changes and I'll merge it. Just include the generator template changes.

@MiguelMadero

This comment has been minimized.

Show comment Hide comment
@MiguelMadero

MiguelMadero Oct 3, 2012

Contributor

Sorry I missed the edit. I did the two commits (re: formatting in templates) in another branch and they're part of another pull request (mde#202) because I thought this issue was closed.

Contributor

MiguelMadero commented Oct 3, 2012

Sorry I missed the edit. I did the two commits (re: formatting in templates) in another branch and they're part of another pull request (mde#202) because I thought this issue was closed.

@larzconwell

This comment has been minimized.

Show comment Hide comment
@larzconwell

larzconwell Oct 3, 2012

Contributor

Ah that's okay, I'll just close this one then.

Contributor

larzconwell commented Oct 3, 2012

Ah that's okay, I'll just close this one then.

@larzconwell larzconwell closed this Oct 3, 2012

@MiguelMadero

This comment has been minimized.

Show comment Hide comment
@MiguelMadero

MiguelMadero Oct 3, 2012

Contributor

Thanks

Contributor

MiguelMadero commented Oct 3, 2012

Thanks

@larzconwell

This comment has been minimized.

Show comment Hide comment
@larzconwell

larzconwell Oct 3, 2012

Contributor

You're welcome, thanks for the PR's love the stuff you're doing!

Contributor

larzconwell commented Oct 3, 2012

You're welcome, thanks for the PR's love the stuff you're doing!

@MiguelMadero

This comment has been minimized.

Show comment Hide comment
@MiguelMadero

MiguelMadero Oct 3, 2012

Contributor

You are welcome. I'm having some fun with my free time :)

Miguel

On Tue, Oct 2, 2012 at 9:37 PM, Larz Conwell notifications@github.comwrote:

You're welcome, thanks for the PR's love the stuff you're doing!


Reply to this email directly or view it on GitHubhttps://github.com/mde/geddy/pull/200#issuecomment-9092247.

Contributor

MiguelMadero commented Oct 3, 2012

You are welcome. I'm having some fun with my free time :)

Miguel

On Tue, Oct 2, 2012 at 9:37 PM, Larz Conwell notifications@github.comwrote:

You're welcome, thanks for the PR's love the stuff you're doing!


Reply to this email directly or view it on GitHubhttps://github.com/mde/geddy/pull/200#issuecomment-9092247.

@mde

This comment has been minimized.

Show comment Hide comment
@mde

mde Oct 3, 2012

Contributor

This is amazing. :)

Contributor

mde commented Oct 3, 2012

This is amazing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment