Minor Changes #202

Closed
wants to merge 15 commits into
from

4 participants

@MiguelMadero

While I was doing the tutorial I did a few minor changes that weren't completely related or needed by the tutorial.

@MiguelMadero MiguelMadero referenced this pull request Oct 5, 2012
Merged

Updated Tutorial #203

@Techwraith

I think we need this one for the SQL adapters, not sure though @mde?

Yes, we need to assume people want auto-increment when using SQL. How is it crashing?

I can't reproduce it. Not sure what the issue was or if there was something else that fixed it :(
I guess I should've documented this better a lot of this issues came from notes when I was playing around.

That said, while trying to reproduce this I found another issue. The int property is created as an integer which causes a validation error ([[model.validatesInteger]])

@Techwraith

@MiguelMadero @mde @larzconwell What's going on with this pull request, can it be merged? Should it be merged? Has it been merged?

@larzconwell

Woah that commit list! haha If we do merge it, the deletions in templates/scaffold/model.ejs shouldn't be deleted. Also I'm not convinced we should add a quickinstall rule to the Makefile.

@MiguelMadero

I just went through all of the commits and this is probably the only useful one.
MiguelMadero@97742e7

The select content tag helper works nice, but I want do add some extra features, so I'll send a separate pull request.

Re: quickinstall. I just wanted a quick way to install it locally without waiting for all the updates, but I should stop using quickinstall or even install and just create a link to the cli in my repo (doh!).

@larzconwell

@MiguelMadero I went ahead and pushed that change you made with the help dialog so I'm going to close this. Commit was 62886dd

@MiguelMadero

Thanks. I created an issue to change the contentTag helper to support select tags.

@larzconwell

Yeah I was just about to comment on there haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment