The model generated by resource and scaffold was different #217

Merged
merged 1 commit into from Oct 9, 2012

Conversation

Projects
None yet
3 participants
Contributor

MiguelMadero commented Oct 9, 2012

No description provided.

Contributor

larzconwell commented Oct 9, 2012

I'll take a look at this in the morning, what's different? I think I noticed the resource model didn't generate the autoIncrementId if the ID is an int but I can't remember for sure.

Contributor

MiguelMadero commented Oct 9, 2012

The code to decide whether or not to add the autoIncrementId was missing in
the resource version. I guess both templates were the same and at some
point they got out of sync.

Miguel

On Tue, Oct 9, 2012 at 1:25 AM, Larz Conwell notifications@github.comwrote:

I'll take a look at this in the morning, what's different? I think I
noticed the resource model didn't generate the autoIncrementId if the ID is
an int but I can't remember for sure.


Reply to this email directly or view it on GitHubhttps://github.com/mde/geddy/pull/217#issuecomment-9248613.

larzconwell added a commit that referenced this pull request Oct 9, 2012

Merge pull request #217 from MiguelMadero/unifyCodeGeneration
The model generated by resource and scaffold was different

@larzconwell larzconwell merged commit e6a0e67 into geddy:master Oct 9, 2012

Contributor

larzconwell commented Oct 9, 2012

Oh awesome, thanks for the pull request man!

Contributor

mde commented Oct 9, 2012

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment