Fixed restarting the cluster workers on code change #381

Merged
merged 1 commit into from Jun 8, 2013

Conversation

Projects
None yet
3 participants
@tstachl
Contributor

tstachl commented Jun 7, 2013

A recent change in mde/utilities@6b8ea03 broke the file watch function. This fixes it however because mde/utilities uses fs.watch instead of fs.watchFile we can't compare the timestamps any longer.

@ben-ng

This comment has been minimized.

Show comment Hide comment
@ben-ng

ben-ng Jun 7, 2013

Contributor

Oh good, it isn't just me then. I was wondering what happened.

On Jun 7, 2013, at 1:56 PM, Thomas Stachl notifications@github.com wrote:

A recent change in mde/utilities@6b8ea03 broke the file watch function. This fixes it however because mde/utilities uses fs.watch instead of fs.watchFile we can't compare the timestamps any longer.

You can merge this Pull Request by running

git pull https://github.com/tstachl/geddy master
Or view, comment on, or merge it at:

mde#381

Commit Summary

fixed restart on code change
File Changes

M lib/cluster/master.js (6)
Patch Links:

https://github.com/mde/geddy/pull/381.patch
https://github.com/mde/geddy/pull/381.diff

Contributor

ben-ng commented Jun 7, 2013

Oh good, it isn't just me then. I was wondering what happened.

On Jun 7, 2013, at 1:56 PM, Thomas Stachl notifications@github.com wrote:

A recent change in mde/utilities@6b8ea03 broke the file watch function. This fixes it however because mde/utilities uses fs.watch instead of fs.watchFile we can't compare the timestamps any longer.

You can merge this Pull Request by running

git pull https://github.com/tstachl/geddy master
Or view, comment on, or merge it at:

mde#381

Commit Summary

fixed restart on code change
File Changes

M lib/cluster/master.js (6)
Patch Links:

https://github.com/mde/geddy/pull/381.patch
https://github.com/mde/geddy/pull/381.diff

mde added a commit that referenced this pull request Jun 8, 2013

Merge pull request #381 from tstachl/master
Fixed restarting the cluster workers on code change

@mde mde merged commit 02a7567 into geddy:master Jun 8, 2013

@mde

This comment has been minimized.

Show comment Hide comment
@mde

mde Jun 8, 2013

Contributor

Merged, thanks!

Contributor

mde commented Jun 8, 2013

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment