Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added check for null on Present validation #47

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

lgomezma commented Mar 23, 2013

No description provided.

lgomezma added some commits Mar 23, 2013

Merge pull request #1 from mde/master
Update my model repo
Check for null on the Present validation
added an extra check for null, since the expression null===undefined will evaluate to false.
Contributor

ben-ng commented Mar 23, 2013

This may not be enough. I did the same thing, but my unit test shows that null values are (wrongly) being accepted. I'll check back once I pinpoint the issue.

(edit)

Nope, just me being stupid. The fix works, I was just using the assert module wrongly.

ben-ng pushed a commit to ben-ng/model that referenced this pull request Mar 23, 2013

mde added a commit that referenced this pull request Mar 23, 2013

@lgomezma lgomezma closed this Mar 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment