From 3d0a3b7f35828379eb3b3faa1e6dcc70e595e096 Mon Sep 17 00:00:00 2001
From: Jerome Wolff <Ic3w0lf@users.noreply.github.com>
Date: Wed, 22 Nov 2023 17:58:10 +0100
Subject: [PATCH] Fix output descriptions and add missing access point outputs

---
 README.md  |  8 +++++---
 outputs.tf | 18 +++++++++++++++---
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 89cd62e..1fadcfe 100644
--- a/README.md
+++ b/README.md
@@ -69,12 +69,14 @@ Comment in these badges if they apply to the repository.
 
 | Name | Description |
 |------|-------------|
+| <a name="output_access_point_arns"></a> [access\_point\_arns](#output\_access\_point\_arns) | ARNs of created access points. |
+| <a name="output_access_point_ids"></a> [access\_point\_ids](#output\_access\_point\_ids) | IDs of created access points. |
 | <a name="output_arn"></a> [arn](#output\_arn) | ARN of filesystem. |
 | <a name="output_dns_name"></a> [dns\_name](#output\_dns\_name) | DNS address of filesystem. |
 | <a name="output_id"></a> [id](#output\_id) | Id of filesystem. |
-| <a name="output_kms_key_id"></a> [kms\_key\_id](#output\_kms\_key\_id) | DNS address of filesystem. |
-| <a name="output_number_of_mount_targets"></a> [number\_of\_mount\_targets](#output\_number\_of\_mount\_targets) | DNS address of filesystem. |
-| <a name="output_size_in_bytes"></a> [size\_in\_bytes](#output\_size\_in\_bytes) | DNS address of filesystem. |
+| <a name="output_kms_key_id"></a> [kms\_key\_id](#output\_kms\_key\_id) | ID of the KMS key used to encrypt the EFS. |
+| <a name="output_number_of_mount_targets"></a> [number\_of\_mount\_targets](#output\_number\_of\_mount\_targets) | Number of mount targets of the EFS file system. |
+| <a name="output_size_in_bytes"></a> [size\_in\_bytes](#output\_size\_in\_bytes) | Size of the EFS file system. |
 
 ## Providers
 
diff --git a/outputs.tf b/outputs.tf
index 51cad7a..ab9bc3d 100644
--- a/outputs.tf
+++ b/outputs.tf
@@ -1,3 +1,4 @@
+## FILE SYSTEM
 output "arn" {
   value       = aws_efs_file_system.main.arn
   description = "ARN of filesystem."
@@ -15,15 +16,26 @@ output "dns_name" {
 
 output "size_in_bytes" {
   value       = aws_efs_file_system.main.size_in_bytes
-  description = "DNS address of filesystem."
+  description = "Size of the EFS file system."
 }
 
 output "number_of_mount_targets" {
   value       = aws_efs_file_system.main.number_of_mount_targets
-  description = "DNS address of filesystem."
+  description = "Number of mount targets of the EFS file system."
 }
 
 output "kms_key_id" {
   value       = aws_efs_file_system.main.kms_key_id
-  description = "DNS address of filesystem."
+  description = "ID of the KMS key used to encrypt the EFS."
+}
+
+## ACCESS POINTS
+output "access_point_ids" {
+  value       = { for key, val in aws_efs_access_point.main : key => val.id }
+  description = "IDs of created access points."
+}
+
+output "access_point_arns" {
+  value       = { for key, val in aws_efs_access_point.main : key => val.arn }
+  description = "ARNs of created access points."
 }