New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find libRCTOneSignal.a #604

Closed
steverob opened this Issue Aug 16, 2018 · 7 comments

Comments

Projects
None yet
7 participants
@steverob
Copy link

steverob commented Aug 16, 2018

Description:
I've followed the instructions for React Native SDK from here - https://documentation.onesignal.com/docs/react-native-sdk-setup

I've added the npm package, performed react-native link and also pod install. Everything went smooth.

Then I proceed to create the Notification Extension. When I get to the part where I'm instructed to add libRCTOneSignal.a in the Link Binary with Libararies setting, I'm not able to find it in the list that Xcode shows. Here's all I see when I search for One Signal:

screen shot 2018-08-16 at 12 55 02 pm

Here is my header search pages setting:
screen shot 2018-08-16 at 12 55 26 pm

Now I tried adding the libreact-native-onesignal.a, but when building I get this linking error:

ld: library not found for -lreact-native-onesignal
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Environment

  1. react-native-one-signal - 3.2.6
  2. RN - 0.55.4
  3. Xcode - 9.2
@steverob

This comment has been minimized.

Copy link
Author

steverob commented Aug 16, 2018

Turns out react-native link did not work correctly as usual :D I just had to manually add the RCTOneSignal project into Libraries and then I was able to add libRCTOneSignal.a

I think it would be nice if you guys can add the instructions for manually linking in addition to react-native link so people can verify if link worked correctly :)

@steverob steverob closed this Aug 16, 2018

@abdul-elah-js

This comment has been minimized.

Copy link

abdul-elah-js commented Nov 18, 2018

how did you add it ?

@nickyhajal

This comment has been minimized.

Copy link

nickyhajal commented Nov 20, 2018

Also trying to figure out exactly how to add the RCTOneSignal project into Libraries

@pacozaa

This comment has been minimized.

Copy link

pacozaa commented Nov 30, 2018

@nickyhajal @abdul-elah-js @steverob Can someone explain how to manually add the RCTOneSignal project into Libraries?

This problem should be in documentation as well.

@sonlexqt

This comment has been minimized.

Copy link

sonlexqt commented Nov 30, 2018

@cassianomon

This comment has been minimized.

Copy link

cassianomon commented Nov 30, 2018

Open node_modules/react-native-onesignal/ios then drag and drop RCTOneSignal.xcodeproj to XCode project folder Libraries, then the libRCTOneSignal.a will appear on the search.

screenshot at nov 30 16-21-30

@rgomezp rgomezp reopened this Jan 25, 2019

@rgomezp

This comment has been minimized.

Copy link
Collaborator

rgomezp commented Jan 29, 2019

I have updated the documentation in the React-Native setup to reflect this. Thanks for bringing this up and helping make our documentation better!

@rgomezp rgomezp closed this Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment