New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: on destroy, set this.registeredEvents = false; #593

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@slorber
Contributor

slorber commented Aug 3, 2018

for android RN restart issue: #583

@slorber

This comment has been minimized.

Contributor

slorber commented Aug 10, 2018

the new release seems to work fine for me so this fix is probably not needed anymore
see #583

@jkasten2

This comment has been minimized.

Collaborator

jkasten2 commented Aug 24, 2018

@slorber Thanks for the PR and following up!

@slorber @Nightsd01 Can you test if pressing the back button to close the app then opening a notification still properly fires the open event to the javascript side? This is the only edge case I can think. If this is not an issue then I think we can close this PR.

For future reference this builds on PR #592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment