Skip to content

Commit

Permalink
Return the response.display_identifier instead of claim_id to the app…
Browse files Browse the repository at this point in the history
…lication.

Signed-off-by: Joshua Peek <josh@joshpeek.com>
  • Loading branch information
nbibler authored and josh committed May 5, 2008
1 parent d9d6e6a commit 1fb6668
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG
@@ -1,3 +1,5 @@
* Return open_id_response.display_identifier to the application instead of .endpoints.claimed_id. [nbibler]

* Add Timeout protection [Rick]

* An invalid identity url passed through authenticate_with_open_id will no longer raise an InvalidOpenId exception. Instead it will return Result[:missing] to the completion block.
Expand Down
2 changes: 1 addition & 1 deletion lib/open_id_authentication.rb
Expand Up @@ -105,7 +105,7 @@ def complete_open_id_authentication
params_with_path = params.reject { |key, value| request.path_parameters[key] }
params_with_path.delete(:format)
open_id_response = timeout_protection_from_identity_server { open_id_consumer.complete(params_with_path, requested_url) }
identity_url = normalize_url(open_id_response.endpoint.claimed_id) if open_id_response.endpoint.claimed_id
identity_url = normalize_url(open_id_response.display_identifier) if open_id_response.display_identifier

case open_id_response.status
when OpenID::Consumer::SUCCESS
Expand Down

0 comments on commit 1fb6668

Please sign in to comment.