Move success message to app's listen callback.#225
Merged
geerlingguy merged 1 commit intogeerlingguy:masterfrom Apr 15, 2022
Merged
Move success message to app's listen callback.#225geerlingguy merged 1 commit intogeerlingguy:masterfrom
app's listen callback.#225geerlingguy merged 1 commit intogeerlingguy:masterfrom
Conversation
express's `server.listen` has an asynchronous nature and it's API enables providing a callback that is fired upon success. Now the success messaage is logged only when the server has been set up and listening on provided socket address, otherwise the error stack trace is printed.
Contributor
Author
|
Explaination: Additional comment: Such solution would enforce good practice, but since this not a web security textbook it's probably best be left as-is for the sake of simplicity. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
express's
server.listenhas an asynchronous nature and it's API enablesproviding a callback that is fired upon success. Now the success messaage
is logged only when the server has been set up and listening on provided
socket address, otherwise the error stack trace is printed.