New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal task updates #8

Closed
wants to merge 4 commits into
base: master
from

Conversation

2 participants
@a-fro
Contributor

a-fro commented Oct 24, 2014

Thanks for your merges earlier. These commits relate to issues I've been having related to Vagrant, GitHub and NFS support. They make it so that:

- The repo only gets checked out if it doesn't exist.
- The hostkey is automatically accepted.
- Drush has sufficient privileges to create the settings.php file (per info at https://www.drupal.org/documentation/install/settings-file).
- The site only gets installed if there is not yet a settings.php file.

Thanks Jeff. Please let me know if you have questions or concerns.

@geerlingguy

This comment has been minimized.

Show comment
Hide comment
@geerlingguy

geerlingguy Nov 17, 2014

Owner

Sorry I haven't had time to look at this; could you rebase your branch so it could be merged?

Owner

geerlingguy commented Nov 17, 2014

Sorry I haven't had time to look at this; could you rebase your branch so it could be merged?

@a-fro

This comment has been minimized.

Show comment
Hide comment
@a-fro

a-fro Nov 17, 2014

Contributor

Thanks. Rebased.

Also, copying a couple of sentences from my part 2 blog post about a final change. Let me know if you think I should create a pull request for it.

"One additional change that I have not created a pull request for relates to the structure I use for Drupal projects. I like to put Drupal in a subfolder of the repository root (typically called docroot). As many readers will realize, this is in large part because we often host on Acquia. And while we're not doing that in this case, I still find it convenient to be able to add other folders (docs, bin scripts, etc.) alongside the Drupal docroot. The final modification we make, then, is to checkout the repository to /var/www/{{ drupal_domain }} (rather than {{ drupal_core_path }}, which points to the docroot folder of the repo)."

Contributor

a-fro commented Nov 17, 2014

Thanks. Rebased.

Also, copying a couple of sentences from my part 2 blog post about a final change. Let me know if you think I should create a pull request for it.

"One additional change that I have not created a pull request for relates to the structure I use for Drupal projects. I like to put Drupal in a subfolder of the repository root (typically called docroot). As many readers will realize, this is in large part because we often host on Acquia. And while we're not doing that in this case, I still find it convenient to be able to add other folders (docs, bin scripts, etc.) alongside the Drupal docroot. The final modification we make, then, is to checkout the repository to /var/www/{{ drupal_domain }} (rather than {{ drupal_core_path }}, which points to the docroot folder of the repo)."

@geerlingguy

This comment has been minimized.

Show comment
Hide comment
@geerlingguy

geerlingguy Mar 2, 2017

Owner

Closing this out, as I'm working on completely rewriting the role for the next release, so it will work a lot more smoothly with multiple Drupal workflows (especially focused on Drupal 8, but also for D7 and somewhat D6). See: #23

Owner

geerlingguy commented Mar 2, 2017

Closing this out, as I'm working on completely rewriting the role for the next release, so it will work a lot more smoothly with multiple Drupal workflows (especially focused on Drupal 8, but also for D7 and somewhat D6). See: #23

@geerlingguy geerlingguy closed this Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment