New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use loop on package module with squash_actions #70

Merged
merged 2 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@arhue
Copy link

arhue commented Oct 21, 2018

To fix issue #68

@arhue

This comment has been minimized.

Copy link
Author

arhue commented Oct 21, 2018

The CI check failed for some reason.

--> Executing Yamllint on files found in /home/travis/build/geerlingguy/geerlingguy.java/...
    /home/travis/build/geerlingguy/geerlingguy.java/tasks/setup-RedHat.yml
      4:32      error    trailing spaces  (trailing-spaces)
@geerlingguy

This comment has been minimized.

Copy link
Owner

geerlingguy commented Oct 21, 2018

@arhue - That means that on line 4, there are extra spaces that should not be there on the end of the line. Please remove those extra spaces and it should pass. (Note: for my own purposes, I use a plugin called TrailingSpaces which highlights them in my IDE.)

@arhue

This comment has been minimized.

Copy link
Author

arhue commented Oct 22, 2018

Well I did the commit/push and the commit showed up fine here initially and then disappeared after a while. If I clone the forked repo and pull the branch, I can see the commit. Just that it doesn't show up on Github. Not sure what's going on here.

commit 12c395713cd85a294da6d336e864470d5f8317d4 (HEAD -> remove-when-items, origin/remove-when-items, origin/remove-head-items, master)
Author: Varun Priolkar <me@varunpriolkar.com>
Date:   Mon Oct 22 04:41:24 2018 +0530

    Remove trailing white space to pass TravisCI check

diff --git a/tasks/setup-RedHat.yml b/tasks/setup-RedHat.yml
index 7d64479..1306945 100644
--- a/tasks/setup-RedHat.yml
+++ b/tasks/setup-RedHat.yml
@@ -1,5 +1,5 @@
 ---
 - name: Ensure Java is installed.
   package:
-    name: "{{ java_packages }}" 
+    name: "{{ java_packages }}"
     state: present

commit ba6550ac7d45b5837ff8016264f871896829300f
Author: Varun Priolkar <me@varunpriolkar.com>
Date:   Sun Oct 21 08:04:29 2018 +0530

    Do not use loop on package module with squash_actions
...
@arhue

This comment has been minimized.

Copy link
Author

arhue commented Oct 22, 2018

@geerlingguy the issue was because of Github having problems. The commit is showing up fine now. Could you please re-run the build and check if it completes?

@geerlingguy geerlingguy merged commit 63debfb into geerlingguy:master Oct 23, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment