Fix tests

[untitaker]

No description provided.

[untitaker]

@geier Please verify that the tests are now not too liberal.

[geier]

I think the tests are too loose now, we can produce pretty broken VTIMEZONE components without failing the tests now.

I was thinking about giving freezegun a try (just learned about it this weekend).

On 30. März 2015 18:22:29 MESZ, Markus Unterwaditzer notifications@github.com wrote:

@geier Please verify that the tests are now not too liberal.

---

Reply to this email directly or view it on GitHub:
#183 (comment)

[untitaker]

I think the tests are too loose now, we can produce pretty broken VTIMEZONE components without failing the tests now.

Which ones, for example?

Syntactically invalid properties are unlikely to occur because icalendar takes care of that for us. The order of the properties doesn't matter, too, and it's also unlikely that we're putting a property into the wrong kind of component.

We could also parse either of them and compare their contents.

[geier]

The way it is now we cannot detect if standard or DST time is +0100 or +0200 (initially this was in the wrong order and we would not detect it with these tests)

[geier]

perhaps the best solution would be to use cached vtimezone components #146

[untitaker]

@geier Please review.

[geier]

I'm much happier with this, please merge if it does indeed work.

[untitaker]

Done.