Decode UTF-8 instead of ASCII #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I don't understand, was this solved in another commit? Should I close this PR? I just saw travis CI is failing, but many failures are completely unrelated to this commit AFAICS. |
|
Hi and thanks for this PR. I just had no time to look at this yet. The tests are failing since some time, this is definitively not your fault. |
|
Closing because this had no answer for 4 years now... 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if hard-coding UTF-8 is correct, but, without knowing anything about CardDAV, I would guess it is. Without this pycarddav is failing with some cards with non-ASCII characters for me.
I didn't update the authors file because the patch is so trivial :)