Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second iteration of a `gel open [gem-name]` CLI command #78

Merged
merged 8 commits into from Aug 6, 2019

Conversation

@sj26
Copy link
Collaborator

commented Aug 6, 2019

Based on #16, addresses a few small issues and adds some extra enhancements.

keithpitt and others added some commits Apr 10, 2019

Handle the case where we can't open an $EDITOR
Co-Authored-By: keithpitt <me@keithpitt.com>

@sj26 sj26 requested a review from matthewd Aug 6, 2019

@sj26 sj26 self-assigned this Aug 6, 2019

Defer the require until the command is run
We're already not perfect on this, but try to maintain a precedent that
we don't avoidably contaminate the standard runtime environment.

@matthewd matthewd merged commit 1cf6653 into gel-rb:master Aug 6, 2019

1 check passed

buildkite/gel Build #235 passed (3 minutes, 43 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.