Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDBM split size #83

Merged
merged 3 commits into from Oct 5, 2019
Merged

SDBM split size #83

merged 3 commits into from Oct 5, 2019

Conversation

@sj26
Copy link
Collaborator

sj26 commented Aug 13, 2019

SDBM's limits are on the key/value pair, not on the value alone. This adjusts the split algorithm to factor in key size as well for a dynamic split size.

@sj26 sj26 force-pushed the sj26:sdbm-split-size branch from 9698a5d to 9a56e43 Aug 27, 2019
sj26 added 2 commits Aug 27, 2019
SDBM's limits are for the combined key/value pair
@sj26 sj26 force-pushed the sj26:sdbm-split-size branch from c5f31c9 to 9a56e43 Aug 27, 2019
@sj26 sj26 requested a review from matthewd Aug 27, 2019
@sj26

This comment has been minimized.

Copy link
Collaborator Author

sj26 commented Aug 27, 2019

@matthewd I fixed the tests here, and added one which demonstrates the issue I hit. Are you happy with it? I'd love to merge it so I'm not running a fork.

@matthewd matthewd merged commit 796203c into gel-rb:master Oct 5, 2019
1 check passed
1 check passed
buildkite/gel Build #248 passed (14 minutes, 23 seconds)
Details
matthewd added a commit that referenced this pull request Dec 31, 2019
matthewd added a commit that referenced this pull request Dec 31, 2019
Support both pre- and post-#83 SDBM key formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.