Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved some parameters from the monitor to the param dictionary #2819

Merged
merged 1 commit into from May 26, 2017
Merged

Moved some parameters from the monitor to the param dictionary #2819

merged 1 commit into from May 26, 2017

Conversation

micheles
Copy link
Contributor

This is very minor. The param dictionary is the right place where to put the parameters, but for historical reasons some parameters were still attached to the monitor object.

@micheles micheles added this to the Engine 2.5.0 milestone May 25, 2017
@micheles micheles requested a review from daniviga May 25, 2017 11:10
daniviga
daniviga approved these changes May 26, 2017
View reviewed changes
Copy link
Contributor

@daniviga daniviga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micheles micheles merged commit ee53efc into master May 26, 2017
@micheles micheles deleted the refa branch May 26, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniviga daniviga daniviga approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
Engine 2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micheles @daniviga