Getting things to work on windows #129

wants to merge 4 commits into


None yet
3 participants

This is a continuation of work done by @bebac for pull request #109

bebac and others added some commits Apr 12, 2013

Fix tempfile binmode on windows
Apparently the ':encoding => 'binary'' option does not change file to binmode, at least not on windows.

This changeset changes file to binary mode by calling binmode on the IO object.
Update geminabox.rb
Change tempfile in atomic_write to binary mode

mlapierre added a commit to mlapierre/geminabox that referenced this pull request Jan 20, 2014


reggieb commented Mar 19, 2014

I've just released 0.12.4. This adds the binary mode changes to the latest version of the Geminabox code. This should fix these issues. Please reopen or log a new issue if you think otherwise.

@reggieb reggieb closed this Mar 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment