Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move content-type into header as required by latest version of webmock #204

Merged
merged 1 commit into from Jun 1, 2015

Conversation

kerrizor
Copy link
Contributor

@kerrizor kerrizor commented Jun 1, 2015

Current master test runs result in this error:

  1) Error:
Geminabox::RubyGemDependencyTest#test_get_list:
ArgumentError: Unknown key: "content_type". Valid keys are: "headers", "status", "body", "exception", "should_timeout"
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/util/hash_validator.rb:12:in `block in validate_keys'
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/util/hash_validator.rb:10:in `each_key'
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/util/hash_validator.rb:10:in `validate_keys'
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/response.rb:80:in `options='
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/response.rb:25:in `initialize'
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/response.rb:15:in `new'
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/response.rb:15:in `response_for'
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/request_stub.rb:21:in `block in to_return'
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/request_stub.rb:21:in `map'
    /Users/kerrimiller/.rvm/gems/ruby-1.9.3-p551/gems/webmock-1.21.0/lib/webmock/request_stub.rb:21:in `to_return'
    /Users/kerrimiller/projects/geminabox/test/units/geminabox/rubygems_dependency_test.rb:13:in `test_get_list'

This is because webmock changed its syntax without providing backwards compatibility. This change fixes this error and allows test suite on master to run cleanly.

tomlea added a commit that referenced this pull request Jun 1, 2015
Move content-type into header as required by latest version of webmock
@tomlea tomlea merged commit 36dc076 into geminabox:master Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants