Support Win32 #98

Closed
wants to merge 3 commits into
from

2 participants

@Donavan

With this commit, Gem reading/writing is forced to binary mode. This allows Win32 support without changing *nix operation.

@Donavan

Not having fork and symlink means a bunch of tests have to be skipped but the code they're testing works (manually tested) under Win32.

@tomlea tomlea commented on an outdated diff Feb 24, 2013
geminabox.gemspec
@@ -25,4 +25,5 @@ Gem::Specification.new do |s|
s.add_development_dependency('capybara')
s.add_development_dependency('capybara-mechanize')
s.add_development_dependency('pry')
+ s.add_development_dependency('pry-debugger')
@tomlea
Gem in a Box member
tomlea added a line comment Feb 24, 2013

Could you remove the pry-debugger line? I think it's making the 1.8.7 travis suite fail. https://travis-ci.org/cwninja/geminabox/jobs/4713561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@yaauie yaauie commented on the diff Mar 1, 2013
test/integration/dependency_api/dependencies_api_test.rb
@@ -4,6 +4,7 @@
class DependenciesApiTest < Geminabox::TestCase
test "push a gem with dependencies" do
+ skip 'Test broken under Win32. (Missing fork)' if RbConfig::CONFIG['host_os'] =~ /mswin|windows|cygwin|mingw32/i
@yaauie
yaauie added a line comment Mar 1, 2013

Could these be better served by skipping unless Process.respond_to?(:fork) ? If that were the case, these could possibly be tested with the win32-process gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Donavan

Will get on the suggested changes. win32-process dropped support for fork as it never worked correctly.

@reggieb
Gem in a Box member

0.12.4 has been release and includes the binary mode fixes required on Windows system. Can you please try this version and raise any new issues you find. Thank you.

@reggieb reggieb closed this Mar 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment