From b2e0c42b9a8fba1b2965e66574b6d230aacae082 Mon Sep 17 00:00:00 2001 From: Roman Kuznetsov Date: Fri, 5 Apr 2024 15:49:52 +0300 Subject: [PATCH] fix: remove hermione-reassert-view --- docs/en/create-hermione-app.md | 1 - docs/ru/create-hermione-app.md | 1 - src/constants/pluginGroups/stabilityGroup.ts | 13 +------------ src/constants/plugins.ts | 1 - src/pluginsConfig/hermione-reassert-view.ts | 18 ------------------ src/pluginsConfig/index.ts | 2 -- 6 files changed, 1 insertion(+), 35 deletions(-) delete mode 100644 src/pluginsConfig/hermione-reassert-view.ts diff --git a/docs/en/create-hermione-app.md b/docs/en/create-hermione-app.md index 3f65f3a..2af6a5f 100644 --- a/docs/en/create-hermione-app.md +++ b/docs/en/create-hermione-app.md @@ -51,7 +51,6 @@ npm init hermione-app my-app -- --lang js - [Safari Commands](https://github.com/gemini-testing/hermione-safari-commands) - To add compatibility for safari mobile - [Test Repeater](https://github.com/gemini-testing/hermione-test-repeater) - To repeat tests the specified number of times regardless of the result - [Url Decorator](https://github.com/gemini-testing/url-decorator) - To add/replace url query params -- [Reassert View](https://github.com/gemini-testing/hermione-reassert-view) - To make screenshot comparison by assertView less strict - [Storybook](https://github.com/gemini-testing/hermione-storybook) - To add ability to write hermione tests on storybook component and speed up their execution - [Html Reporter](https://github.com/gemini-testing/html-reporter) - To generate html-reports for showing passed/failed tests, screenshot diffs, error messages, stacktraces, meta-info and so on - [Oauth](https://github.com/gemini-testing/hermione-oauth) - To set authorization header with OAuth token diff --git a/docs/ru/create-hermione-app.md b/docs/ru/create-hermione-app.md index e616a8a..8ee6396 100644 --- a/docs/ru/create-hermione-app.md +++ b/docs/ru/create-hermione-app.md @@ -47,7 +47,6 @@ npm init hermione-app my-app -- --lang js - [Safari Commands](https://github.com/gemini-testing/hermione-safari-commands) - Чтобы поддержать работу для браузера `safari` на мобильных устройствах - [Test Repeater](https://github.com/gemini-testing/hermione-test-repeater) - Чтобы повторять тесты указанное количество раз вне зависимости от результата - [Url Decorator](https://github.com/gemini-testing/url-decorator) - Чтобы добавить/заменить параметры запроса в `url` команде -- [Reassert View](https://github.com/gemini-testing/hermione-reassert-view) - Чтобы сделать скриншотное тестирование менее строгим - [Storybook](https://github.com/gemini-testing/hermione-storybook) - Чтобы писать тесты на `storybook` компонентах и ускорить время их выполнения - [Html Reporter](https://github.com/gemini-testing/html-reporter) - Чтобы генерировать отчеты для отображения прошедших/упавших тестах, разницы между скриншотами, ошибкок, мета информации - [Oauth](https://github.com/gemini-testing/hermione-oauth) - Чтобы установить заголовок авторизации с OAuth токеном diff --git a/src/constants/pluginGroups/stabilityGroup.ts b/src/constants/pluginGroups/stabilityGroup.ts index f10333a..d9baa59 100644 --- a/src/constants/pluginGroups/stabilityGroup.ts +++ b/src/constants/pluginGroups/stabilityGroup.ts @@ -1,20 +1,9 @@ import type { PluginGroup } from "../../types/toolOpts"; -import { - HERMIONE_REASSERT_VIEW, - HERMIONE_RETRY_COMMAND, - RETRY_LIMITER, - HERMIONE_RETRY_PROGRESSIVE, - HERMIONE_TEST_REPEATER, -} from "../plugins"; +import { HERMIONE_RETRY_COMMAND, RETRY_LIMITER, HERMIONE_RETRY_PROGRESSIVE, HERMIONE_TEST_REPEATER } from "../plugins"; const unstableGroup: PluginGroup = { description: "Increase stability of unstable tests", plugins: [ - { - description: "Make screenshot comparison by assertView less strict", - plugin: HERMIONE_REASSERT_VIEW, - default: false, - }, { description: "Retry assertView on comparison fail", plugin: HERMIONE_RETRY_COMMAND, diff --git a/src/constants/plugins.ts b/src/constants/plugins.ts index 4798386..a63c7a9 100644 --- a/src/constants/plugins.ts +++ b/src/constants/plugins.ts @@ -1,7 +1,6 @@ export const HTML_REPORTER = "html-reporter/hermione"; export const HERMIONE_TEST_REPEATER = "hermione-test-repeater"; export const HERMIONE_RETRY_COMMAND = "hermione-retry-command"; -export const HERMIONE_REASSERT_VIEW = "hermione-reassert-view"; export const HERMIONE_SAFARI_COMMANDS = "hermione-safari-commands"; export const HERMIONE_RETRY_PROGRESSIVE = "hermione-retry-progressive"; export const HERMIONE_STORYBOOK = "hermione-storybook/plugin"; diff --git a/src/pluginsConfig/hermione-reassert-view.ts b/src/pluginsConfig/hermione-reassert-view.ts deleted file mode 100644 index f85a4e6..0000000 --- a/src/pluginsConfig/hermione-reassert-view.ts +++ /dev/null @@ -1,18 +0,0 @@ -import { HERMIONE_REASSERT_VIEW } from "../constants/plugins"; -import type { HermioneConfig } from "../types/hermioneConfig"; - -export default { - name: HERMIONE_REASSERT_VIEW, - fn: (config: HermioneConfig): void => { - config.plugins![HERMIONE_REASSERT_VIEW] = { - __comment: "https://github.com/gemini-testing/hermione-reassert-view", - enabled: true, - browsers: Object.keys(config.browsers), - maxDiffSize: { - width: 15, - height: 15, - }, - dry: false, - }; - }, -}; diff --git a/src/pluginsConfig/index.ts b/src/pluginsConfig/index.ts index 2847c52..eb5c881 100644 --- a/src/pluginsConfig/index.ts +++ b/src/pluginsConfig/index.ts @@ -12,7 +12,6 @@ import hermioneTabsCloser from "./hermione-tabs-closer"; import hermioneGlobalHook from "./hermione-global-hook"; import hermioneTestRepeater from "./hermione-test-repeater"; import hermioneRetryCommand from "./hermione-retry-command"; -import hermioneReassertView from "./hermione-reassert-view"; import hermioneSafariCommands from "./hermione-safari-commands"; import hermioneHeadlessChrome from "./hermione-headless-chrome"; import hermionePluginsProfiler from "./hermione-plugins-profiler"; @@ -22,7 +21,6 @@ const pluginsConfig = [ htmlReporter, hermioneTestRepeater, hermioneRetryCommand, - hermioneReassertView, hermionePluginsProfiler, hermioneTabsCloser, retryLimiter,