Support erb in config file && allow silent branch-failure #4

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@petehamilton

Allows injection of API key from environment using

<%= ENV['GEMNASIUM_API_KEY'] %>

If you want the config file versioned.

Also allows you to prevent an error-return if the current branch is not the specified gemnasium one.

@gonzoyumo
Gemnasium member

Thanks for providing this. Can you please add some tests too?

You may also avoid bumping the version, we'll do it when releasing the gem and updating the changelog accordingly.
And why bumping to 2.0.2? There is no 2.0.1 release. Please revert this.

@petehamilton petehamilton - Support erb in YAML config file
- Allow ignoring of pushes on untracked branches

Allows injection of API key from environment using
<%= ENV['GEMNASIUM_API_KEY'] %>
7fe75d5
@petehamilton

Sure, apologies for version bump, wasn't really thinking. Will update with tests shortly.

@gonzoyumo
Gemnasium member

Getting close :) Can you please update the gemnasium_spec.rb too ? to ensure command behavior on a non tracked branch with the --ignore-branch option

@twelvelabs twelvelabs added a commit to voxmedia/gemnasium-gem that referenced this pull request Mar 24, 2014
@twelvelabs twelvelabs Add an --ignore-branch option for 'gemnasium push'
Mostly copied from gemnasium#4, but renamed and including additional requested specs.
7b427aa
@fcat

The two features have in implemented in v3.1.0.

@fcat fcat closed this Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment